Messages in this thread | | | Date | Tue, 22 Jan 2013 22:07:55 +0800 | From | Feng Tang <> | Subject | Re: [RFC PATCH 1/5] x86: Add cpu capability flag X86_FEATURE_TSC_S3_NOTSTOP |
| |
On Mon, Jan 21, 2013 at 09:58:32AM -0600, H. Peter Anvin wrote: > On 01/21/2013 01:59 AM, Feng Tang wrote: > >>> > >> We have an existed "TSC always running in C3+" feature and name it as > >> X86_FEATURE_NONSTOP_TSC, so how about naming it with the same style, > >> like X86_FEATURE_NONSTOP_TSC_S3? > > > > Yeah, actually I used a name X86_FEATURE_xxx_TSC, then I did a grep, > > and found there is no unified name convention for TSC, so I chose such > > a name. > > > > I think NONSTOP_TSC_S3 is quite a bit more consistent than S3_NOTSTOP...
Got it, will use that in new version.
Thanks Feng
| |