Messages in this thread | | | Date | Tue, 22 Jan 2013 09:20:10 +0300 | From | Dan Carpenter <> | Subject | Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net |
| |
On Mon, Jan 21, 2013 at 11:44:55PM +0000, Mark Einon wrote: > On 19 January 2013 11:03, Dan Carpenter <dan.carpenter@oracle.com> wrote: > <snip> > > > > et131x_get_regs() has endian bugs calling et131x_mii_read(). > > > </snip> > > Hi Dan, > > Could you be a bit more descriptive about the issues you think there > are with these calls? >
Sorry, that was sloppy on my part. Here's what I meant:
et131x_mii_read(adapter, MII_BMCR, (u16 *)®s_buff[num++]);
That puts the number in the 2 high bits which works for little endian systems but not for big endian. It should be something like:
u16 tmp;
et131x_mii_read(adapter, MII_BMCR, &tmp); regs_buff[num++] = tmp;
regards, dan carpenter
| |