lkml.org 
[lkml]   [2013]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 4/8] MFD: ti_am335x_tscadc: add device tree binding information
Date
Hi,

On Sun, Jan 20, 2013 at 03:58:14, Lars-Peter Clausen wrote:
> Hi,
>
> On 01/18/2013 11:48 AM, Patil, Rachna wrote:
> > From: "Patil, Rachna" <rachna@ti.com>
> >
> > Signed-off-by: Patil, Rachna <rachna@ti.com>
> > ---
> > .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 35 ++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
> > b/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
> > new file mode 100644
> > index 0000000..c13c492
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
> > @@ -0,0 +1,35 @@
> > +Texas Instruments - TSC / ADC multi-functional device
> > +
> > +ti_tscadc is a multi-function device with touchscreen and ADC on chip.
> > +This document describes the binding for mfd device.
> > +
> > +Required properties:
> > +- compatible: "ti,ti-tscadc"
> > +- reg: Specifies the address of MFD block
> > +- interrupts: IRQ line connected to the main SoC
> > +- interrupt-parent: The parent interrupt controller
>
> The subnodes and their properties also need documentation.

Ok. I Will add this.

>
> > +
> > +Optional properties:
> > +- ti,hwmods: Hardware information related to TSC/ADC MFD device
> > +
> > +Example:
> > +
> > + tscadc: tscadc@44e0d000 {
> > + compatible = "ti,ti-tscadc";
> > + reg = <0x44e0d000 0x1000>;
> > +
> > + interrupt-parent = <&intc>;
> > + interrupts = <16>;
> > + ti,hwmods = "adc_tsc";
> > +
> > + tsc {
> > + wires = <4>;
> > + x-plate-resistance = <200>;
> > + steps-to-configure = <5>;
> > + wire-config = <0x00 0x11 0x22 0x33>;
>
> Non-standard properties should have a vendor prefix.

Ok. I will fix this in the next version of the patch set.

Regards,
Rachna



\
 
 \ /
  Last update: 2013-01-22 11:03    [W:0.055 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site