lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC][Update 2][PATCH 4/4] ACPI / PM: Expose lists of device power resources to user space
    Date
    On Monday, January 21, 2013 12:58:46 PM Greg Kroah-Hartman wrote:
    > On Mon, Jan 21, 2013 at 02:08:16PM +0100, Rafael J. Wysocki wrote:
    > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    > >
    > > Since ACPI power resources are going to be used more extensively on
    > > new hardware platforms, it is necessary to allow user space (powertop
    > > in particular) to look at the lists of power resources corresponding
    > > to different power states of devices for diagnostics and control
    > > purposes.
    > >
    > > For this reason, for each power state of an ACPI device node using
    > > power resources create a special attribute group under the device
    > > node's directory in sysfs containing links to sysfs directories
    > > representing the power resources in that list. The names of the
    > > new attribute groups are "power_resources_<state>", where <state>
    > > is the state name i.e. "D0", "D1", "D2", or "D3hot".
    > >
    > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    >
    > You aren't calling sysfs_add_link() here, so why did you export it in
    > the previous patch?

    Well, unnecessarily.

    Thanks,
    Rafael


    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2013-01-22 03:41    [W:4.119 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site