Messages in this thread | | | From | Kukjin Kim <> | Subject | RE: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp | Date | Mon, 21 Jan 2013 17:27:30 -0800 |
| |
amit kachhap wrote: > > Hi Rui, > > Thanks for the review comments, > On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui <rui.zhang@intel.com> wrote: > > Hi, Amit, > > > > On Sun, 2013-01-06 at 16:08 -0800, Amit Daniel Kachhap wrote: > >> This patch adds support to set the emulated temperature method in > >> thermal zone (sensor). After setting this feature thermal zone must > >> report this temperature and not the actual temperature. The actual > >> implementation of this emulated temperature is based on sensor > >> capability or platform specific. This is useful in debugging different > >> temperature threshold and its associated cooling action. Writing 0 on > >> this node should disable emulation. > > > > Question: > > will this bring hardware issue? Say, critical temperature reached while > > in emulation mode? > No emulation does cause any h/w issue. > > > > As this is for debug purpose, I'd prefer to have a seperate Kconfig > > option for this feature. > Yes agreed. Will re-submit with kconfig option. > > > >> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Hi Zhang,
Once Amit addresses comments from you, I think, this looks good to Exynos SoCs. And this is _really_ needed.
Feel free to add my ack on this 1st and 2nd patches:
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
| |