Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC PATCH v5 3/8] PCI: add a blocking notifier chain for PCI bus addition/removal | Date | Mon, 21 Jan 2013 23:46:01 +0100 |
| |
On Tuesday, January 22, 2013 12:18:55 AM Jiang Liu wrote: > On 01/21/2013 07:54 AM, Rafael J. Wysocki wrote: > > On Saturday, January 19, 2013 12:07:41 AM Jiang Liu wrote: > >> When adding/removing a PCI bus, some other components want to be > snip > >> + > >> +void pci_bus_call_notifier(struct pci_bus *bus, unsigned long code) > >> +{ > >> + int ret; > >> + > >> + ret = blocking_notifier_call_chain(&pci_bus_notifier_chain, > >> + code, bus); > >> + WARN_ON(ret != NOTIFY_DONE && ret != NOTIFY_OK); > > > > I'm not sure if this is a good idea. WARN_ON() is quite a heavy tool. > Hi Rafael, > How about WARN_ONCE() here?
Well, that depends on what you think it will be useful for.
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |