Messages in this thread | | | From | Peter Hüwe <> | Subject | Re: [PATCH 1/2] staging/comedi: Add pci_driver.name to skel driver | Date | Mon, 21 Jan 2013 22:25:29 +0100 |
| |
Am Montag, 21. Januar 2013, 21:56:22 schrieb H Hartley Sweeten: > On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote: > > This patch adds the comedi_driver.name to pci_driver.name > > to the skel driver, so we can remove the workaround in drivers.c > > > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > > --- > > > > drivers/staging/comedi/drivers/skel.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/skel.c > > b/drivers/staging/comedi/drivers/skel.c index e2d7970..4a40498 100644 > > --- a/drivers/staging/comedi/drivers/skel.c > > +++ b/drivers/staging/comedi/drivers/skel.c > > @@ -713,6 +713,7 @@ static void skel_pci_remove(struct pci_dev *dev) > > > > } > > > > static struct pci_driver skel_pci_driver = { > > > > + .name = "dummy" > > > > .id_table = skel_pci_table, > > .probe = &skel_pci_probe, > > .remove = &skel_pci_remove > > Hmm... I was just about to post a rebase of the last part of my drivers.c > cleanup that included this and your 2/2 patch. > > Oh well... Rebase again... > > FWIW, for both patches. > > Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
It's okay to drop my patches so you don't have to rebase.
(I posted a version with the missing comma nevertheless)
Thanks, Peter
| |