Messages in this thread | | | Date | Tue, 22 Jan 2013 01:32:18 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 2/3] AMD IOMMUv2 PC resource management hooks |
| |
On Mon, Jan 21, 2013 at 02:20:57PM -0600, Steven L. Kinney wrote: > +u8 amd_iommu_v2_get_max_pc_banks(u16 devid) > +{ > + struct amd_iommu *iommu; > + > + /* locate the iommu governing the devid */ > + iommu = amd_iommu_rlookup_table[devid]; > + > + if (iommu) > + return iommu->max_banks; > + > + return -ENODEV; > +} > +EXPORT_SYMBOL(amd_iommu_v2_get_max_pc_banks);
Hi Steven, may not it be better to return int here, instead of u8?
| |