lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/3] dma: edma: add device_channel_caps() support
    On Mon, Jan 21, 2013 at 03:16:32AM +0000, Vinod Koul wrote:
    > On Sun, Jan 20, 2013 at 11:51:08AM -0500, Matt Porter wrote:
    > > The explanation in the cover letter mentions that dmaengine_slave_config() is
    > > required to be called prior to dmaengine_get_channel_caps(). If we
    > > switch to the alternative API, then that would go away including the
    > > dependency on direction.
    > Nope you got that wrong!

    :) Yes, dropped the ball there, should have been for the api to make
    sense as implemented:

    1. Allocate a DMA slave channel
    2. Set slave and controller specific parameters
    2a. [Optionally] Get channel capabilities
    3. Get a descriptor for transaction
    4. Submit the transaction
    5. Issue pending requests and wait for callback notification

    FWIW, the implementation example in the davinci mmc client driver shows
    proper use as in the correct documentation above.

    -Matt


    \
     
     \ /
      Last update: 2013-01-21 20:01    [W:2.751 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site