lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/21] NTB: declare unused variables
On Mon, Jan 21, 2013 at 10:50:55AM -0700, Jon Mason wrote:
> On Sun, Jan 20, 2013 at 03:42:28PM -0800, Greg KH wrote:
> > On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote:
> > > Tag pci_device_id in ntb_pci_probe as unused function parameters. This
> > > corrects issues found by 'EXTRA_CFLAGS=-W'.
> >
> > Why would you build the kernel with that option? This isn't needed, so
>
> Per Documentation/SubmitChecklist:
>
> 22: Newly-added code has been compiled with `gcc -W' (use "make
> EXTRA_CFLAGS=-W"). This will generate lots of noise, but is good for
> finding bugs like "warning: comparison between signed and unsigned".
>
>
> I was attempting to comply with that suggestion. If this is
> unnecessary, then I can toss these, but I don't really see them
> hurting anything.

It's messy and unneeded, so I'd not recommend using it. As the
checklist says, it generates a lot of noise, and is good for finding
real bugs, this isn't a "real" bug at all.

> Same goes for the other 2 patches found via 'EXTRA_CFLAGS=-W'.

Understood, I've not applied them either :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-01-21 20:01    [W:0.060 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site