lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/15] drivers/infiniband/hw/mlx4/sysfs.c: adjust duplicate test
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    Delete successive tests to the same location. The code tested the result
    of a previous allocation, that itself was already tested. It is changed to
    test the result of the most recent allocation.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @s exists@
    local idexpression y;
    expression x,e;
    @@

    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
    { ... when forall
    return ...; }
    ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
    when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
    { ... when forall
    return ...; }
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/infiniband/hw/mlx4/sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/mlx4/sysfs.c b/drivers/infiniband/hw/mlx4/sysfs.c
    index 5b2a01d..97516eb 100644
    --- a/drivers/infiniband/hw/mlx4/sysfs.c
    +++ b/drivers/infiniband/hw/mlx4/sysfs.c
    @@ -732,7 +732,7 @@ int mlx4_ib_device_register_sysfs(struct mlx4_ib_dev *dev)
    dev->ports_parent =
    kobject_create_and_add("ports",
    kobject_get(dev->iov_parent));
    - if (!dev->iov_parent) {
    + if (!dev->ports_parent) {
    ret = -ENOMEM;
    goto err_ports;
    }


    \
     
     \ /
      Last update: 2013-01-21 18:21    [W:4.267 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site