Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v9 10/11] PCI: Add match_driver in struct pci_dev | Date | Mon, 21 Jan 2013 13:41:59 +0100 |
| |
On Sunday, January 20, 2013 09:22:04 PM Yinghai Lu wrote: > On Sun, Jan 20, 2013 at 3:15 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > On Thursday, January 17, 2013 11:53:21 PM Yinghai Lu wrote: > >> with that we could move out attaching driver for pci device, > >> out of device_add for pci hot add path. > >> > >> pci_bus_attach_device() will attach driver to pci device. > > > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > for the code, but you still aren't saying in the changelog why the change > > is needed. > > Thanks. > > Please check if the changelog is good to you.
It's fine by me.
Thanks, Rafael
> --- > Subject: [PATCH] PCI: Skip attaching driver in device_add() > > We want to add pci device to device tree as early as possible but > delay attach driver in next following path. > > To make that patch smaller, in this patch: > > We add match_driver field in pci_dev and default vaule is false, it will > make pci_bus_match fail, so device_add will skip attaching driver, > then pci_bus_attach_device() will set match_driver to true so > pci_bus_match will return true and device_attach will attach driver > to pci device. > > --- -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |