lkml.org 
[lkml]   [2013]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dma: sh/shdma-base.c: remove unnecessary null pointer check
On Tue, Jan 15, 2013 at 01:23:48AM +0100, Cong Ding wrote:
> the variable chan is dereferenced in line 635, so it is no reason to check
> null again in line 641.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/dma/sh/shdma-base.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
> index f4cd946..4acb85a 100644
> --- a/drivers/dma/sh/shdma-base.c
> +++ b/drivers/dma/sh/shdma-base.c
> @@ -638,9 +638,6 @@ static int shdma_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
> unsigned long flags;
> int ret;
>
> - if (!chan)
> - return -EINVAL;
> -
> switch (cmd) {
> case DMA_TERMINATE_ALL:
> spin_lock_irqsave(&schan->chan_lock, flags);
Applied, Thanks

--
~Vinod


\
 
 \ /
  Last update: 2013-01-20 15:41    [W:0.031 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site