lkml.org 
[lkml]   [2013]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fat: eliminate iterations in fat_search_long in case of EOD
Date
Namjae Jeon <linkinjeon@gmail.com> writes:

> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> When searching a directory for names, we can stop checking for further
> entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The
> current code traverses the cluster chain of a directory until a hit is
> found or till the last cluster for that directory, ignoring the EOD mark.
> Fix this.

f_pos still works fine after this change?

> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ravishankar N <ravi.n1@samsung.com>
> ---
> fs/fat/dir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 58bf744..cde0e69 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -484,10 +484,10 @@ parse_record:
> nr_slots = 0;
> if (de->name[0] == DELETED_FLAG)
> continue;
> + if (!de->name[0])
> + goto end_of_dir;
> if (de->attr != ATTR_EXT && (de->attr & ATTR_VOLUME))
> continue;
> - if (de->attr != ATTR_EXT && IS_FREE(de->name))
> - continue;
> if (de->attr == ATTR_EXT) {
> int status = fat_parse_long(inode, &cpos, &bh, &de,
> &unicode, &nr_slots);

--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2013-01-20 12:41    [W:0.051 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site