Messages in this thread | | | Date | Sun, 20 Jan 2013 23:04:28 -0500 (EST) | Subject | Re: [PATCH 5/5] drivers: atm: checkpatch.pl fixed coding style issues in eni.c | From | David Miller <> |
| |
From: Patrik Karlin <patrik.karlin@gmail.com> Date: Mon, 21 Jan 2013 00:12:55 +0100
> This patch fixes statement placement around if/else/for statments > as suggested by checkpatch.pl > > Signed-off-by: Patrik Kårlin <patrik.karlin@gmail.com>
This patch set is a good example of why nobody should fix up coding style in such a robotic way in response to codingstyle.pl complaints.
> - ATM_MAX_AAL5_PDU) eff = (length+3) >> 2; > + ATM_MAX_AAL5_PDU)
I bet you didn't even notice that in this change you are adding trailing whitespace, the exact problem you fixed up for this file in a previous patch of the series.
I really would encourage you to work on something else entirely.
Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |