Messages in this thread Patch in this message | | | Date | Sun, 20 Jan 2013 23:14:43 +0100 (CET) | From | Jesper Juhl <> | Subject | [PATCH][trivial] pcmcia: avoid static analysis complaint about use-after-free |
| |
Coverity complains about a use after free for 'res1' and 'res2' since we use the value of the pointers in a 'dev_dbg()' after they have been freed. That's not really a problem, but it still seems cleaner to defer freeing until we are completely done with the pointers.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- drivers/pcmcia/rsrc_nonstatic.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 430a9ac..065704c 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -369,12 +369,12 @@ static int do_validate_mem(struct pcmcia_socket *s, } } - free_region(res2); - free_region(res1); - dev_dbg(&s->dev, "cs: memory probe 0x%06lx-0x%06lx: %p %p %u %u %u", base, base+size-1, res1, res2, ret, info1, info2); + free_region(res2); + free_region(res1); + if ((ret) || (info1 != info2) || (info1 == 0)) return -EINVAL; -- 1.7.1
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |