Messages in this thread | | | Date | Sun, 20 Jan 2013 20:35:42 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/4] (Was: ptrace: prevent PTRACE_SETREGS from corrupting stack) |
| |
On 01/20, Oleg Nesterov wrote: > > > And we'd need to make sure to re-set the WAKEKILL flag not just in all > > the callers of ptrace_check_attach(), but also in the failure case of > > wait_task_inactive(). I'm not sure it can actually fail if we cleared > > WAKEKILL, but it's all pretty subtle. > > Afaics it can't fail if we clear WAKEKILL... So 2/4 assumes it should > always succeed and adds the warning.
Argh! It can, exactly because we can not kill may_ptrace_stop() yet. I'll update and resend 2/4.
Oleg.
| |