Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: [PATCH] module: prevent warning when finit_module a 0 sized file | Date | Thu, 03 Jan 2013 11:11:03 +1030 |
| |
Sasha Levin <sasha.levin@oracle.com> writes:
> If we try to finit_module on a file sized 0 bytes vmalloc will > scream and spit out a warning. > > Since modules have to be bigger than 0 bytes anyways we can just > check that beforehand and avoid the warning.
Applied, but I added the comment you somehow missed :)
Thanks, Rusty.
diff --git a/kernel/module.c b/kernel/module.c index 250092c..41bc118 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2527,6 +2527,13 @@ static int copy_module_from_fd(int fd, struct load_info *info) err = -EFBIG; goto out; } + + /* Don't hand 0 to vmalloc, it whines. */ + if (stat.size == 0) { + err = -EINVAL; + goto out; + } + info->hdr = vmalloc(stat.size); if (!info->hdr) { err = -ENOMEM;
| |