lkml.org 
[lkml]   [2013]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH V2] rtc: add RTC driver for TPS6586x
On Thu, 27 Dec 2012 20:29:14 +0530
Laxman Dewangan <ldewangan@nvidia.com> wrote:

> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
> > Hi Laxman,
> >
> > On Friday 21 December 2012 20:42:28 you wrote:
> >
> >> +
> >> + /* Set epoch start as 00:00:00:01:01:2000 */
> >> + rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
> > any reason why you hard coded it to 2000? All boards I know use 2009, so with
> > this patch, everyone needs to set his clock again.
> >
>
> No specific reason. If 2009 should be default then I can push patch to
> set it as 2009.

I'd like to get this into Linus soon so let's get it finished. I
assume it's merely this?

--- a/drivers/rtc/rtc-tps6586x.c~rtc-add-rtc-driver-for-tps6586x-fix2
+++ a/drivers/rtc/rtc-tps6586x.c
@@ -260,8 +260,8 @@ static int tps6586x_rtc_probe(struct pla
rtc->dev = &pdev->dev;
rtc->irq = platform_get_irq(pdev, 0);

- /* Set epoch start as 00:00:00:01:01:2000 */
- rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
+ /* Set epoch start as 00:00:00:01:01:2009 */
+ rtc->epoch_start = mktime(2009, 1, 1, 0, 0, 0);

/* 1 kHz tick mode, enable tick counting */
ret = tps6586x_update(tps_dev, RTC_CTRL,
_


\
 
 \ /
  Last update: 2013-01-03 01:21    [W:0.073 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site