Messages in this thread | | | Date | Sat, 19 Jan 2013 19:40:10 +0530 | From | Vineet Gupta <> | Subject | Re: [PATCH v2 19/76] ARC: Signal handling |
| |
On Saturday 19 January 2013 08:53 AM, Al Viro wrote: > On Fri, Jan 18, 2013 at 05:54:33PM +0530, Vineet Gupta wrote: >> +SYSCALL_DEFINE0(rt_sigreturn) >> +{ >> + struct rt_sigframe __user *sf; >> + unsigned int magic; >> + int err; >> + struct pt_regs *regs = task_pt_regs(current); > ITYM current_pt_regs()...
Done.
> >> + if (unlikely(is_do_ss_needed(magic))) >> + if (do_sigaltstack(&sf->uc.uc_stack, NULL, regs->sp) == -EFAULT) > if (!restore_altstack(&sf->uc.uc_stack)) > please... > >> + stk.ss_sp = (void __user *)current->sas_ss_sp; >> + stk.ss_flags = sas_ss_flags(regs->sp); >> + stk.ss_size = current->sas_ss_size; >> + err |= __copy_to_user(&sf->uc.uc_stack, &stk, sizeof(stk)); > that would be > err |= __save_altstack(&frame->uc.uc_stack, regs->sp); >
Actually altstack consolidation tracking changes are already present in patch 41/76 - which has other 3.8 specific bits too. This is more of a reflection of my 3.7 baseline and a subsequent migration to 3.8. But you are right, it is creating undue confusion - I'll chop-n-dice-n-squash those bits into appropriate patches.
Thx, -Vineet
| |