Messages in this thread | | | Date | Fri, 18 Jan 2013 13:39:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mm: Define set_pmd_at for numabalance for CONFIG_PARAVIRT |
| |
On Fri, 18 Jan 2013 10:33:24 +0100 Michal Hocko <mhocko@suse.cz> wrote:
> CONFIG_PARAVIRT defines set_pmd_at only for CONFIG_TRANSPARENT_HUGEPAGE > which leads to the following compile errors when randconfig selected > CONFIG_NUMA_BALANCING && CONFIG_PARAVIRT && !CONFIG_TRANSPARENT_HUGEPAGE: > > mm/mprotect.c: In function ___change_pmd_protnuma___: > mm/mprotect.c:120: error: implicit declaration of function ___set_pmd_at___ > > mm/memory.c: In function ___do_pmd_numa_page___: > mm/memory.c:3529: error: implicit declaration of function ___set_pmd_at___ > > Signed-off-by: Michal Hocko <mhocko@suse.cz> > --- > arch/x86/include/asm/paravirt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index a0facf3..f551e89 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -528,7 +528,7 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte); > } > > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_NUMA_BALANCING) > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd) > {
Confused - there is no "#ifdef CONFIG_TRANSPARENT_HUGEPAGE" in there in any kernel version I can think of.
| |