lkml.org 
[lkml]   [2013]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver
On Fri, 18 Jan 2013, David Miller wrote:

> > + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |
> > + USB_RECIP_DEVICE, value, index, data, size);
>
> This is not indented properly. When a function call takes up
> multiple lines, the text on the second and subsequent lines must
> be left justified to the first column after the openning parenthesis
> of the function call, like this:
>
> function(arg1, arg2,
> arg3, arg4);
>
> You must use the appropriate combination of TAB and space characters
> to achieve this. If you are trying to only use TAB characters, you
> are doing it wrong.

Documentation/CodingStyle doesn't mention this. Does the networking
stack have its own special requirements, not listed in CodingStyle?

Alan Stern

P.S: The standard I have tried to follow for USB code is to indent
continuation lines by two tab stops more than the first line,
regardless of whether the break occurs inside a function call. I have
seen other people consistently indent continuation lines by 1/2 tab
stop (i.e., four spaces) beyond the first line.



\
 
 \ /
  Last update: 2013-01-18 22:22    [W:0.036 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site