Messages in this thread | | | Date | Fri, 18 Jan 2013 21:19:28 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] serial: tegra: Switch to using struct tty_port |
| |
On Friday 18 January 2013 02:07 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Jan 17, 2013 at 10:07:51AM -0700, Stephen Warren wrote: >> On 01/17/2013 06:31 AM, Thierry Reding wrote: >>> Many of the tty functions were converted to use a struct tty_port >>> instead of a struct tty_struct. Update the Tegra driver accordingly to >>> avoid build breakage. >> I tested that this does indeed fix the build warnings. I didn't test the >> resultant driver. > I wonder if this would have been caught earlier if it had errored out > instead of outputting lots of warnings. Looking at the gcc documentation > there doesn't seem to be a way to turn this kind of warning into an > error. That would leave -Werror as the only option to have the compiler > abort on this kind of warning. > > Globally enabling -Werror might not be a good idea and I'm sure it must > have been discussed in the past (even though Google doesn't show any > references). In this particular case the warnings are actually severe > errors and are very likely to cause buggy behaviour so it would be good > to catch them at compile time. Warnings are unfortunately quite easy to > ignore. > > I know I can always use EXTRA_CFLAGS to change this for local builds, > but maybe getting more people to do this would be worthwhile. >
There was no issue when patch created. The change happen in the api with same time when patch created and so become out of sync.
API changed with commit on 1/16. Serial driver also get added on 1/16.
Author: Jiri Slaby <jslaby@suse.cz> 2013-01-03 20:23:06 Committer: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2013-01-16 12:00:15
Follows: v3.8-rc3 Precedes: next-20130117
TTY: switch tty_flip_buffer_push
| |