lkml.org 
[lkml]   [2013]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()
On 01/18/2013 05:02 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote:
>> +/* only PHY and UNUSED modes don't need TLL */
>> +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) &&\
>> + (x != OMAP_EHCI_PORT_MODE_PHY))
>
> Growl.
>
> These parens do not make anything safer at all - they just obfuscate. The
> safe version of the above macro would have been:
>
> #define omap_usb_mode_needs_tll(x) ((x) != OMAP_USBHS_PORT_MODE_UNUSED &&\
> (x) != OMAP_EHCI_PORT_MODE_PHY)
>
> If you're going to use a macro argument in an expression, it needs parens.
> Simple expressions like a != b && c != d do _not_ need parens.
>

Yikes, that was brain dead stuff from me ;). Will fix.

cheers,
-roger


\
 
 \ /
  Last update: 2013-01-18 16:41    [W:0.057 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site