Messages in this thread | | | Date | Fri, 18 Jan 2013 15:09:02 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 2/2] perf stat: add interval printing |
| |
SNIP
> >> - if (status != -1) > >> + if (status != -1 && !interval) > >> print_stat(argc, argv); > > > > The way this is done prevents final stats to be printed, > > which seems unfortunate. > > > This is on purpose. All we care about here is the spaced deltas. > Note that I also removed the shadow stats. Tried to make them > work for a while but it did not make sense especially for -a -A. > I don't think it even works right now. > > > Actually I don't mind that much, because I haven't even thought about > > this feature, but looks like it could be done separately with no affect > > to final counts. > > > Initially I had it as raw_counts, prev_raw_counts. But then it would > cause problems with the stats. So I simplified everything, it uses > less memory and gives me the output I care about. > > If you want total count, then don't use this new option. The results > are to be fed to a plotter, so the final counts are useless and complicate > the post-processing.
ok, agreed
jirka
> > > But since you probably use it mostly for feeding some graph ploting > > program, it's probably fine.. just feels wrong ;-)
| |