lkml.org 
[lkml]   [2013]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer check
On Wed, Jan 16, 2013 at 11:30:44PM +0100, Cong Ding wrote:
> The pointer tty is dereferened in line 3135, so it is not necessary to check
> null again in line 3140.

I don't know if we actually need to check the parameter tty from being null,
but when checking the rest of the file, most other functions don't check it.

In any case, gcc is quite likely to remove that check due to the
earlier dereference, so removing it is probably acceptable.

> Signed-off-by: Cong Ding <dinggnu@gmail.com>

Thanks, I'll take it in the CRIS tree.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com


\
 
 \ /
  Last update: 2013-01-18 15:01    [W:0.054 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site