Messages in this thread | | | Date | Fri, 18 Jan 2013 15:13:59 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: wm8994: Convert wm8994_ldo2_ops to use regulator_list_voltage_linear |
| |
On Fri, Jan 18, 2013 at 11:58:33AM +0800, Axel Lin wrote:
> + /* LDO2, id starts from 0 */ > + if (id == 1) { > + switch (wm8994->type) { > + case WM8994: > + wm8994_ldo_desc[id].min_uV = 900000; > + wm8994_ldo_desc[id].uV_step = 100000; > + break;
This isn't going to work in the (admittedly unlikely) case where we have two different devices using this driver in the system. We shouldn't be modifying static data like this.
| |