Messages in this thread Patch in this message |  | | From | Haojun Bao <> | Date | Thu, 17 Jan 2013 00:01:51 -0800 | Subject | [PATCH] Do not tweak clock in pxa serial write() function |
| |
The write() function could be used by printk(), which is atomic and tweaking clock there can cause "BUG: sleeping function called from invalid context".
Signed-off-by: Bao Haojun <hjbao@marvell.com> --- drivers/tty/serial/pxa.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 2764828..fa1d5ae 100644 --- a/drivers/tty/serial/pxa.c +++ b/drivers/tty/serial/pxa.c @@ -673,7 +673,6 @@ serial_pxa_console_write(struct console *co, const char *s, unsigned int count) unsigned long flags; int locked = 1; - clk_prepare_enable(up->clk); local_irq_save(flags); if (up->port.sysrq) @@ -702,7 +701,6 @@ serial_pxa_console_write(struct console *co, const char *s, unsigned int count) spin_unlock(&up->port.lock); local_irq_restore(flags); - clk_disable_unprepare(up->clk); } #ifdef CONFIG_CONSOLE_POLL -- 1.7.10.4
|  |