Messages in this thread |  | | Date | Thu, 17 Jan 2013 10:41:59 +0000 | From | Richard Mortimer <> | Subject | Re: [PATCH v2] sparc: kernel/sbus.c: fix memory leakage |
| |
On 16/01/2013 22:01, Cong Ding wrote: > the variable iommu and strbuf are not freed if it goes to error. > > Signed-off-by: Cong Ding <dinggnu@gmail.com> > --- > arch/sparc/kernel/sbus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/sparc/kernel/sbus.c b/arch/sparc/kernel/sbus.c > index 1271b3a..78aa26b 100644 > --- a/arch/sparc/kernel/sbus.c > +++ b/arch/sparc/kernel/sbus.c > @@ -656,6 +656,8 @@ static void __init sbus_iommu_init(struct platform_device *op) > return; > > fatal_memory_error: > + kfree(strbuf);
strbuf will be uninitialized if the iommu allocation fails. I don't have a particular preference for how to fix this but tend to dislike initial assignment with NULL because it hides other control flow issues.
Regards
Richard
> + kfree(iommu); > prom_printf("sbus_iommu_init: Fatal memory allocation error.\n"); > } > >
|  |