Messages in this thread |  | | Date | Thu, 17 Jan 2013 08:05:47 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [ 037/221] iscsi-target: Fix bug in handling of ExpStatSN ACK during u32 wrap-around |
| |
On Thu, Jan 17, 2013 at 01:37:24PM +0000, Ben Hutchings wrote: > On Tue, 2013-01-15 at 10:49 -0800, Greg Kroah-Hartman wrote: > > 3.7-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Steve Hodgson <steve@purestorage.com> > > > > commit 64c13330a38935120501b19c97a3e6095747c7a1 upstream. > > > > This patch fixes a bug in the hanlding of initiator provided ExpStatSN and > > individual iscsi_cmd->stat_sn comparision during iscsi_conn->stat_sn > > wrap-around within iscsit_ack_from_expstatsn() code. > > > > This bug would manifest itself as iscsi_cmd descriptors not being Acked > > by a lower ExpStatSn, causing them to be leaked until an iSCSI connection > > or session reinstatement event occurs to release all commands. > > > > Also fix up two other uses of incorrect CmdSN SNA comparison to use wrapper > > usage from include/scsi/iscsi_proto.h. > [...] > > You'll need to add this fix: > > commit 64fe4f4f181cc2fe97d4176bf6ee6e3725ae33ec > Author: Roland Dreier <roland@purestorage.com> > Date: Mon Jan 7 11:45:16 2013 -0800 > > iscsi-target: Fix CmdSN comparison (use cmd->cmd_sn instead of cmd->stat_sn)
Thanks for that, now queued up.
greg k-h
|  |