Messages in this thread |  | | Date | Thu, 17 Jan 2013 10:15:51 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request |
| |
On Thu, 17 Jan 2013, Roger Quadros wrote:
> This driver does not request any gpios so don't free them. > Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd > with ehci-omap in use. > > CC: Alan Stern <stern@rowland.harvard.edu> > > Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> --- > drivers/usb/host/ehci-omap.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c > index 134c789..b96a4bf 100644 > --- a/drivers/usb/host/ehci-omap.c > +++ b/drivers/usb/host/ehci-omap.c > @@ -288,7 +288,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct usb_hcd *hcd = dev_get_drvdata(dev); > - struct usbhs_omap_platform_data *pdata = dev->platform_data; > > usb_remove_hcd(hcd); > disable_put_regulator(dev->platform_data); > @@ -298,13 +297,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev) > pm_runtime_put_sync(dev); > pm_runtime_disable(dev); > > - if (pdata->phy_reset) { > - if (gpio_is_valid(pdata->reset_gpio_port[0])) > - gpio_free(pdata->reset_gpio_port[0]); > - > - if (gpio_is_valid(pdata->reset_gpio_port[1])) > - gpio_free(pdata->reset_gpio_port[1]); > - } > return 0; > } > >
|  |