Messages in this thread |  | | Date | Thu, 17 Jan 2013 08:11:52 -0500 | From | Mark Lord <> | Subject | Re: BUG at net/sunrpc/svc_xprt.c:921 |
| |
On 13-01-14 11:17 AM, Mark Lord wrote: > > Here's the code with the BUG() at net/sunrpc/svc_xprt.c line 921: > > /* > * Remove a dead transport > */ > static void svc_delete_xprt(struct svc_xprt *xprt) > { > struct svc_serv *serv = xprt->xpt_server; > struct svc_deferred_req *dr; > > /* Only do this once */ > if (test_and_set_bit(XPT_DEAD, &xprt->xpt_flags)) > BUG();
Shouldn't there also be a return statement after the BUG() line, inside the if-stmt ?
I mean, the comment says "only do this once", but it actually appears to end up doing it twice, despite the test.
??
|  |