lkml.org 
[lkml]   [2013]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fix setup_efi_pci()
From
Date
On Mon, 2013-01-14 at 08:59 +0000, Jan Beulich wrote:
> This fixes three issues:
> - missing parentheses around a flag test
> - wrong memory type used for allocation intended to persist post-boot
> - four similar build warnings on 32-bit (casts between different size
> pointers and integers)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> ---
> arch/x86/boot/compressed/eboot.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Jan, could you resubmit items 2 and 3 as separate patches please? Item 1
on your list has already been fixed in Linus' tree,

commit 886d751a2ea99a160f2d0a472231566d9cb0cf58
Author: Sasha Levin <sasha.levin@oracle.com>
Date: Thu Dec 20 14:11:33 2012 -0500

x86, efi: correct precedence of operators in setup_efi_pci

With the current code, the condition in the if() doesn't make much sense due
precedence of operators.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Link: http://lkml.kernel.org/r/1356030701-16284-25-git-send-email-sasha.levi
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

--
Matt Fleming, Intel Open Source Technology Center



\
 
 \ /
  Last update: 2013-01-17 14:01    [W:0.121 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site