Messages in this thread Patch in this message |  | | From | sjur.brandeland@stericss ... | Subject | [PATCH] remoteproc: Deallocate firmware image on shutdown | Date | Thu, 17 Jan 2013 13:25:00 +0100 |
| |
From: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>
Fixes coherent memory leakage, caused by non-deallocated firmware image chunk.
Signed-off-by: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com> ---
This fix is intended for v3.8.
Thanks, Sjur
drivers/remoteproc/ste_modem_rproc.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/remoteproc/ste_modem_rproc.c b/drivers/remoteproc/ste_modem_rproc.c index a7743c0..fb95c42 100644 --- a/drivers/remoteproc/ste_modem_rproc.c +++ b/drivers/remoteproc/ste_modem_rproc.c @@ -240,6 +240,8 @@ static int sproc_drv_remove(struct platform_device *pdev) /* Unregister as remoteproc device */ rproc_del(sproc->rproc); + dma_free_coherent(sproc->rproc->dev.parent, SPROC_FW_SIZE, + sproc->fw_addr, sproc->fw_dma_addr); rproc_put(sproc->rproc); mdev->drv_data = NULL; @@ -297,10 +299,13 @@ static int sproc_probe(struct platform_device *pdev) /* Register as a remoteproc device */ err = rproc_add(rproc); if (err) - goto free_rproc; + goto free_mem; return 0; +free_mem: + dma_free_coherent(rproc->dev.parent, SPROC_FW_SIZE, + sproc->fw_addr, sproc->fw_dma_addr); free_rproc: /* Reset device data upon error */ mdev->drv_data = NULL; -- 1.7.5.4
|  |