lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: xhci: fix incorrect bit test
Hi Nickolai,

Thanks for catching this. Don't worry about sending a new patch with
the short description for the commit, I'll fix that when I send it off.

Sarah Sharp

On Mon, Jan 07, 2013 at 10:39:31PM -0500, Nickolai Zeldovich wrote:
> Fix incorrect bit test that originally showed up in
> 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index cbb44b7..06921b6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1698,7 +1698,7 @@ static void handle_port_status(struct xhci_hcd *xhci,
> faked_port_index + 1);
> if (slot_id && xhci->devs[slot_id])
> xhci_ring_device(xhci, slot_id);
> - if (bus_state->port_remote_wakeup && (1 << faked_port_index)) {
> + if (bus_state->port_remote_wakeup & (1 << faked_port_index)) {
> bus_state->port_remote_wakeup &=
> ~(1 << faked_port_index);
> xhci_test_and_clear_bit(xhci, port_array,
> --
> 1.7.10.4
>


\
 
 \ /
  Last update: 2013-01-17 02:21    [W:0.079 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site