lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path
Hello.

On 01/16/2013 05:43 PM, Roger Quadros wrote:

> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path.

> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-tll.c | 36 +++++++++++-------------------------
> 1 files changed, 11 insertions(+), 25 deletions(-)

> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 9658e18..53ed10b 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
[...]
> - base = ioremap(res->start, resource_size(res));
> + base = devm_request_and_ioremap(dev, res);
> if (!base) {
> - dev_err(dev, "TLL ioremap failed\n");
> ret = -ENOMEM;

-EADDRNOTAVAIL as the comment to devm_request_and_ioremap() suggests.

> - goto err_usbtll_p2_fck;
> + dev_err(dev, "Resource request/ioremap failed:%d\n", ret);
> + goto err_res;
> }

WBR, Sergei



\
 
 \ /
  Last update: 2013-01-16 20:24    [W:0.149 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site