lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 092/222] bcma: mips: fix clearing device IRQ
    Date
    3.5.7.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>

    commit cbbc0138efe1dcd5426b8fc5d87741f5057aee72 upstream.

    We were using wrong IRQ number so clearing wasn't working at all.
    Depending on a platform this could result in a one device having two
    interrupts assigned. On BCM4706 this resulted in all IRQs being broken.

    Cc: Hauke Mehrtens <hauke@hauke-m.de>
    Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
    Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/bcma/driver_mips.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
    index c3e9dff..041fddf 100644
    --- a/drivers/bcma/driver_mips.c
    +++ b/drivers/bcma/driver_mips.c
    @@ -115,7 +115,7 @@ static void bcma_core_mips_set_irq(struct bcma_device *dev, unsigned int irq)
    bcma_read32(mdev, BCMA_MIPS_MIPS74K_INTMASK(0)) &
    ~(1 << irqflag));
    else
    - bcma_write32(mdev, BCMA_MIPS_MIPS74K_INTMASK(irq), 0);
    + bcma_write32(mdev, BCMA_MIPS_MIPS74K_INTMASK(oldirq), 0);

    /* assign the new one */
    if (irq == 0) {
    --
    1.7.9.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-01-16 20:24    [W:2.623 / U:1.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site