Messages in this thread | | | Date | Wed, 16 Jan 2013 15:03:23 -0300 | Subject | Re: [PATCH 2/4] staging: media: go7007: firmware protection Protection for unfirmware load | From | Ezequiel Garcia <> |
| |
Hi Volokh,
On Wed, Jan 16, 2013 at 10:42 AM, Volokh Konstantin <volokh84@gmail.com> wrote: > On Wed, Jan 16, 2013 at 04:35:45PM +0300, Dan Carpenter wrote: >> The problem is that the firmware was being unloaded on disconnect? >> > If no firmware was loaded (no exists,wrong or some error) then rmmod fails with OOPS, > so need some protection stuff
This explanation should be part of the commit message. It helps people understand what you're doing and why it's needed.
BTW, none of this 4-patch series has a detailed commit message besides the commit title. I know they are small patches, but I'm sure you can do better than that!
-- Ezequiel
| |