lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dw_dmac: switch to use dma_pool API
From
Date
On Wed, 2013-01-16 at 15:18 +0530, Viresh Kumar wrote: 
> > @@ -1125,7 +1083,6 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan)
> > + memset(desc, 0, sizeof(struct dw_desc));
> > +
>
> why do we need this? We always fill all fields of this structure, isn't it?

No, it is not. At least we don't fill everything at
alloc_chan_resources() stage. Previous code used kzalloc. I decide to
use memset to avoid potential side effects in the future.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy


\
 
 \ /
  Last update: 2013-01-16 15:21    [W:0.068 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site