lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] pwm: pwm-tiecap: Low power sleep support
Date
On Mon, Jan 14, 2013 at 12:40:34, Thierry Reding wrote:
> On Thu, Jan 10, 2013 at 06:33:44PM +0530, Philip Avinash wrote:
> > In low power modes of AM33XX platforms, peripherals power is cut off.
> > This patch supports low power sleep transition support for ECAP driver.
> >
> > Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> > ---
...
> > +struct ecap_regs {
> > + u32 cap3;
> > + u32 cap4;
> > + u16 ecctl2;
> > +};
>
> Perhaps name this ecap_context for consistency with the EHRPWM driver?

I will correct it.

>
> > +void ecap_pwm_save_reg(struct ecap_pwm_chip *pc)
> > +{
> > + pm_runtime_get_sync(pc->chip.dev);
> > + pc->ctx.ecctl2 = readw(pc->mmio_base + ECCTL2);
> > + pc->ctx.cap4 = readl(pc->mmio_base + CAP4);
> > + pc->ctx.cap3 = readl(pc->mmio_base + CAP3);
> > + pm_runtime_put_sync(pc->chip.dev);
> > +}
> > +
> > +void ecap_pwm_restore_reg(struct ecap_pwm_chip *pc)
> > +{
> > + writel(pc->ctx.cap3, pc->mmio_base + CAP3);
> > + writel(pc->ctx.cap4, pc->mmio_base + CAP4);
> > + writew(pc->ctx.ecctl2, pc->mmio_base + ECCTL2);
> > +}
>
> Then rename these ecap_pwm_{save,restore}_context()?

I will correct in next version.

...

> Same comment as for the EHRPWM driver applies here.

I will correct in next version

Thanks
Avinash

>
> Thierry
>



\
 
 \ /
  Last update: 2013-01-16 14:01    [W:0.073 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site