lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ACPI: check zero length in acpi_rs_get_aml_length
Date
There is a bug somewhere in the code that does not set the resource
length. This makes the loop in acpi_rs_get_aml_length to loop forever.
So it is a good thing to have the check even if the bug is fixed.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/acpi/acpica/rscalc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/rscalc.c b/drivers/acpi/acpica/rscalc.c
index da178b4..c128f2e 100644
--- a/drivers/acpi/acpica/rscalc.c
+++ b/drivers/acpi/acpica/rscalc.c
@@ -198,7 +198,8 @@ acpi_rs_get_aml_length(struct acpi_resource * resource, acpi_size * size_needed)

/* Validate the descriptor type */

- if (resource->type > ACPI_RESOURCE_TYPE_MAX) {
+ if (resource->type > ACPI_RESOURCE_TYPE_MAX ||
+ WARN_ON(!resource->length)) {
return_ACPI_STATUS(AE_AML_INVALID_RESOURCE_TYPE);
}

--
1.8.1



\
 
 \ /
  Last update: 2013-01-16 13:01    [W:0.036 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site