lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 028/171] ext4: fix memory leak in ext4_xattr_set_acl()s error path
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>

    commit 24ec19b0ae83a385ad9c55520716da671274b96c upstream.

    In ext4_xattr_set_acl(), if ext4_journal_start() returns an error,
    posix_acl_release() will not be called for 'acl' which may result in a
    memory leak.

    This patch fixes that.

    Reviewed-by: Lukas Czerner <lczerner@redhat.com>
    Signed-off-by: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/acl.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/fs/ext4/acl.c
    +++ b/fs/ext4/acl.c
    @@ -410,8 +410,10 @@ ext4_xattr_set_acl(struct dentry *dentry

    retry:
    handle = ext4_journal_start(inode, EXT4_DATA_TRANS_BLOCKS(inode->i_sb));
    - if (IS_ERR(handle))
    - return PTR_ERR(handle);
    + if (IS_ERR(handle)) {
    + error = PTR_ERR(handle);
    + goto release_and_out;
    + }
    error = ext4_set_acl(handle, inode, type, acl);
    ext4_journal_stop(handle);
    if (error == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))



    \
     
     \ /
      Last update: 2013-01-16 02:21    [W:4.072 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site