lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 055/221] ext4: fix possible use after free with metadata csum
    Date
    3.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit aeb1e5d69a5be592e86a926be73efb38c55af404 upstream.

    Commit fa77dcfafeaa introduces block bitmap checksum calculation into
    ext4_new_inode() in the case that block group was uninitialized.
    However we brelse() the bitmap buffer before we attempt to checksum it
    so we have no guarantee that the buffer is still there.

    Fix this by releasing the buffer after the possible checksum
    computation.

    Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/ialloc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/ialloc.c
    +++ b/fs/ext4/ialloc.c
    @@ -762,7 +762,6 @@ got:

    BUFFER_TRACE(block_bitmap_bh, "dirty block bitmap");
    err = ext4_handle_dirty_metadata(handle, NULL, block_bitmap_bh);
    - brelse(block_bitmap_bh);

    /* recheck and clear flag under lock if we still need to */
    ext4_lock_group(sb, group);
    @@ -775,6 +774,7 @@ got:
    ext4_group_desc_csum_set(sb, group, gdp);
    }
    ext4_unlock_group(sb, group);
    + brelse(block_bitmap_bh);

    if (err)
    goto fail;



    \
     
     \ /
      Last update: 2013-01-16 02:21    [W:2.257 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site