lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 046/221] libata: set dma_mode to 0xff in reset
    Date
    3.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aaron Lu <aaron.lu@intel.com>

    commit 5416912af75de9cba5d1c75b99a7888b0bbbd2fb upstream.

    ata_device->dma_mode's initial value is zero, which is not a valid dma
    mode, but ata_dma_enabled will return true for this value. This patch
    sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
    not return true for this case, or it will cause problem for pata_acpi.

    The corrsponding bugzilla page is at:
    https://bugzilla.kernel.org/show_bug.cgi?id=49151

    Reported-by: Phillip Wood <phillip.wood@dunelm.org.uk>
    Signed-off-by: Aaron Lu <aaron.lu@intel.com>
    Tested-by: Szymon Janc <szymon@janc.net.pl>
    Tested-by: Dutra Julio <dutra.julio@gmail.com>
    Acked-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/ata/libata-core.c | 1 +
    drivers/ata/libata-eh.c | 1 +
    2 files changed, 2 insertions(+)

    --- a/drivers/ata/libata-core.c
    +++ b/drivers/ata/libata-core.c
    @@ -2560,6 +2560,7 @@ int ata_bus_probe(struct ata_port *ap)
    * bus as we may be talking too fast.
    */
    dev->pio_mode = XFER_PIO_0;
    + dev->dma_mode = 0xff;

    /* If the controller has a pio mode setup function
    * then use it to set the chipset to rights. Don't
    --- a/drivers/ata/libata-eh.c
    +++ b/drivers/ata/libata-eh.c
    @@ -2657,6 +2657,7 @@ int ata_eh_reset(struct ata_link *link,
    * bus as we may be talking too fast.
    */
    dev->pio_mode = XFER_PIO_0;
    + dev->dma_mode = 0xff;

    /* If the controller has a pio mode setup function
    * then use it to set the chipset to rights. Don't



    \
     
     \ /
      Last update: 2013-01-16 00:21    [W:4.085 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site