Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge | Date | Tue, 15 Jan 2013 23:00:25 +0100 |
| |
On Tuesday, January 15, 2013 07:54:22 AM Yinghai Lu wrote: > On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu <yinghai@kernel.org> wrote: > > On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > >>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void) > >>> > >>> return 0; > >>> } > >>> + > >>> +/* > >>> + * Separated from drivers/pci/hotplug/acpiphp_glue.c > >>> + * only support root bridge > >>> + */ > >> > >> This comment will be useless after applying the patch. > >> > >>> + > >>> +static LIST_HEAD(acpi_root_bridge_list); > >>> +struct acpi_root_bridge { > >>> + struct list_head list; > >>> + acpi_handle handle; > >>> + u32 flags; > >>> +}; > >> > >> We have struct acpi_pci_root already. Why do we need this in addition? > > > > will address that in following patch. > > please check if you are ok with merging attached 5 patches in to one > patches instead.
Do I understand correctly that you're asking whether to merge the attached patches together, so as to obtain one combined patch?
If so, yes, I'd like that to be done.
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |