Messages in this thread | | | Date | Tue, 15 Jan 2013 16:42:45 -0200 | From | Herton Ronaldo Krzesinski <> | Subject | Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound |
| |
On Sun, Jan 13, 2013 at 05:43:14PM +0000, Ben Hutchings wrote: > 3.2-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Weston Andros Adamson <dros@netapp.com> > > commit 6168f62cbde8dcf4f58255794efbcdb8df603959 upstream. > > The OPEN operation has no way to differentiate an open for read and an > open for execution - both look like read to the server. This allowed > users to read files that didn't have READ access but did have EXEC access, > which is obviously wrong. > > This patch adds an ACCESS call to the OPEN compound to handle the > difference between OPENs for reading and execution. Since we're going > through the trouble of calling ACCESS, we check all possible access bits > and cache the results hopefully avoiding an ACCESS call in the future. > > Signed-off-by: Weston Andros Adamson <dros@netapp.com> > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> > [bwh: Backported to 3.2: > - Adjust context > - #include <linux/export.h> in fs/nfs/dir.c] > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
This 3.2 series lacks commit ae2bb03236fc978bdf673c19d39832500793b83c pointed in its changelog as fixing a regression from this one.
-- []'s Herton
| |