lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 1/1] clk-divider: fix is_power_of_two()
From
Date
On Tue, 2013-01-15 at 10:28 +0000, James Hogan wrote:
> The macro is_power_of_two() in clk-divider.c was defined as !(i & ~i)
> which is always true. Correct it to !(i & (i - 1)).
[]
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
[]
> @@ -29,8 +29,8 @@
[]
> -#define div_mask(d) ((1 << (d->width)) - 1)
> -#define is_power_of_two(i) !(i & ~i)
> +#define div_mask(d) ((1 << ((d)->width)) - 1)
> +#define is_power_of_two(i) (!((i) & ((i) - 1)))

Use is_power_of_2 in log2.h instead?




\
 
 \ /
  Last update: 2013-01-15 20:23    [W:0.061 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site