Messages in this thread | | | Date | Tue, 15 Jan 2013 15:46:17 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH 1/3] slub: correct to calculate num of acquired objects in get_partial_node() |
| |
On Tue, 15 Jan 2013, Joonsoo Kim wrote:
> There is a subtle bug when calculating a number of acquired objects. > After acquire_slab() is executed at first, page->inuse is same as > page->objects, then, available is always 0. So, we always go next > iteration.
page->inuse is always < page->objects because the partial list is not used for slabs that are fully allocated. page->inuse == page->objects means that no objects are available on the slab and therefore the slab would have been removed from the partial list.
> After that, we don't need return value of put_cpu_partial(). > So remove it.
Hmmm... The code looks a bit easier to understand than what we have right now.
Could you try to explain it better?
| |