Messages in this thread | | | From | Sjur BRENDELAND <> | Date | Tue, 15 Jan 2013 16:11:31 +0100 | Subject | RE: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation |
| |
Hi Ido,
> On Fri, Dec 14, 2012 at 05:06:56PM +0100, Sjur Brændeland wrote: > > Postpone the registration of virtio devices until all > > vritio ring resource has been allocated. > > This fixes the following bug: The driver's start callback > > is called before all vring notify ids are allocated and > > max_notifyid will be increased after starting the remoteproc. > > It seems that this patch wont solve this issue, since > rproc_add_virtio_dev eventually increases max_notifyid, so the same > problem will simply occur at a later stage. > > Also, it seems that the original rproc_add_virtio_dev calls were not > removed, so devices would be added twice. > > If max_notifyid needs to be set before the first virtio device is added, > how about counting the number of notification ids in advance before > adding the devices, by traversing the resource list twice?
OK, I'll just simply count the number of vrings registered then.
Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |