Messages in this thread | | | From | Sjur BRENDELAND <> | Date | Tue, 15 Jan 2013 16:14:19 +0100 | Subject | RE: [RFCv2 11/11] remoteproc: Support virtio config space. |
| |
Hi Ido,
> > +void rproc_virtio_get(struct virtio_device *vdev, unsigned offset, > > + void *buf, unsigned > len) > > +{ > > + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > > + void *cfg = &rvdev->rsc->vring[rvdev->rsc->num_of_vrings]; > > + memcpy(buf, cfg + offset, len); > > +} > > + > > +void rproc_virtio_set(struct virtio_device *vdev, unsigned offset, > > + const void *buf, unsigned len) > > +{ > > + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > > + void *cfg = &rvdev->rsc->vring[rvdev->rsc->num_of_vrings]; > > + memcpy(cfg + offset, buf, len); > > } > > Perhaps verify the offset and length to avoid overwriting memory?
OK, I'll add checks on size of the config space.
Regards, Sjur
| |